cphipps/changedetection.io
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Notifications regression bug in 0.39.15 - only sent the first notification URL

Browse Source
This commit is contained in:
dgtlmoon
2022-06-15 15:05:52 +02:00
parent 4a91505af5
commit fba2b1a39d
3 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
README.md
View File

@@ -56,9 +56,9 @@ Easily see what changed, examine by word, line, or individual character.
Please :star: star :star: this project and help it grow! https://github.com/dgtlmoon/changedetection.io/ Please :star: star :star: this project and help it grow! https://github.com/dgtlmoon/changedetection.io/
### Target elements with the Visual Selector tool. ### Filter by elements using the Visual Selector tool.
Available when connected to a <a href="https://github.com/dgtlmoon/changedetection.io/wiki/Playwright-content-fetcher">playwright content fetcher</a> (available also as part of our subscription service) Available when connected to a <a href="https://github.com/dgtlmoon/changedetection.io/wiki/Playwright-content-fetcher">playwright content fetcher</a> (included as part of our subscription service)
<img src="https://raw.githubusercontent.com/dgtlmoon/changedetection.io/master/docs/visualselector-anim.gif" style="max-width:100%;" alt="Self-hosted web page change monitoring context difference " title="Self-hosted web page change monitoring context difference " /> <img src="https://raw.githubusercontent.com/dgtlmoon/changedetection.io/master/docs/visualselector-anim.gif" style="max-width:100%;" alt="Self-hosted web page change monitoring context difference " title="Self-hosted web page change monitoring context difference " />

1
changedetectionio/__init__.py
View File

@@ -1263,6 +1263,7 @@ def notification_runner():
else: else:
now = datetime.now() now = datetime.now()
sent_obj = None
try: try:
from changedetectionio import notification from changedetectionio import notification

10
changedetectionio/notification.py
View File

@@ -48,6 +48,7 @@ def process_notification(n_object, datastore):
# Anything higher than or equal to WARNING (which covers things like Connection errors) # Anything higher than or equal to WARNING (which covers things like Connection errors)
# raise it as an exception # raise it as an exception
apobjs=[] apobjs=[]
sent_objs=[]
for url in n_object['notification_urls']: for url in n_object['notification_urls']:
apobj = apprise.Apprise(debug=True) apobj = apprise.Apprise(debug=True)
@@ -102,10 +103,13 @@ def process_notification(n_object, datastore):
if log_value and 'WARNING' in log_value or 'ERROR' in log_value: if log_value and 'WARNING' in log_value or 'ERROR' in log_value:
raise Exception(log_value) raise Exception(log_value)
# Return what was sent for better logging sent_objs.append({'title': n_title,
return {'title': n_title,
'body': n_body, 'body': n_body,
'body_format': n_format} 'url' : url,
'body_format': n_format})
# Return what was sent for better logging - after the for loop
return sent_objs
# Notification title + body content parameters get created here. # Notification title + body content parameters get created here.