fix: address unhandled promise rejections & bump node to v16.13 (#2398)

* fix: unhandled promise rejections

* build(deps): bump node from 14.18 to 16.13

* fix: unhandled promise rejection in new Plex users endpoint

* fix: build error

Co-authored-by: Ryan Cohen <ryan@sct.dev>

server/subscriber/IssueCommentSubscriber.ts

@@ -12,6 +12,7 @@ import IssueComment from '../entity/IssueComment';
 import Media from '../entity/Media';
 import notificationManager, { Notification } from '../lib/notifications';
 import { Permission } from '../lib/permissions';
+import logger from '../logger';
 
 @EventSubscriber()
 export class IssueCommentSubscriber
@@ -26,62 +27,67 @@ export class IssueCommentSubscriber
     let image: string;
     const tmdb = new TheMovieDb();
 
-    const issue = (
-      await getRepository(IssueComment).findOne({
-        where: { id: entity.id },
-        relations: ['issue'],
-      })
-    )?.issue;
-    if (!issue) {
-      return;
-    }
+    try {
+      const issue = (
+        await getRepository(IssueComment).findOneOrFail({
+          where: { id: entity.id },
+          relations: ['issue'],
+        })
+      ).issue;
 
-    const media = await getRepository(Media).findOne({
-      where: { id: issue.media.id },
-    });
-    if (!media) {
-      return;
-    }
-
-    if (media.mediaType === MediaType.MOVIE) {
-      const movie = await tmdb.getMovie({ movieId: media.tmdbId });
-
-      title = `${movie.title}${
-        movie.release_date ? ` (${movie.release_date.slice(0, 4)})` : ''
-      }`;
-      image = `https://image.tmdb.org/t/p/w600_and_h900_bestv2${movie.poster_path}`;
-    } else {
-      const tvshow = await tmdb.getTvShow({ tvId: media.tmdbId });
-
-      title = `${tvshow.name}${
-        tvshow.first_air_date ? ` (${tvshow.first_air_date.slice(0, 4)})` : ''
-      }`;
-      image = `https://image.tmdb.org/t/p/w600_and_h900_bestv2${tvshow.poster_path}`;
-    }
-
-    const [firstComment] = sortBy(issue.comments, 'id');
-
-    if (entity.id !== firstComment.id) {
-      // Send notifications to all issue managers
-      notificationManager.sendNotification(Notification.ISSUE_COMMENT, {
-        event: `New Comment on ${
-          issue.issueType !== IssueType.OTHER
-            ? `${IssueTypeName[issue.issueType]} `
-            : ''
-        }Issue`,
-        subject: title,
-        message: firstComment.message,
-        comment: entity,
-        issue,
-        media,
-        image,
-        notifyAdmin: true,
-        notifyUser:
-          !issue.createdBy.hasPermission(Permission.MANAGE_ISSUES) &&
-          issue.createdBy.id !== entity.user.id
-            ? issue.createdBy
-            : undefined,
+      const media = await getRepository(Media).findOneOrFail({
+        where: { id: issue.media.id },
       });
+
+      if (media.mediaType === MediaType.MOVIE) {
+        const movie = await tmdb.getMovie({ movieId: media.tmdbId });
+
+        title = `${movie.title}${
+          movie.release_date ? ` (${movie.release_date.slice(0, 4)})` : ''
+        }`;
+        image = `https://image.tmdb.org/t/p/w600_and_h900_bestv2${movie.poster_path}`;
+      } else {
+        const tvshow = await tmdb.getTvShow({ tvId: media.tmdbId });
+
+        title = `${tvshow.name}${
+          tvshow.first_air_date ? ` (${tvshow.first_air_date.slice(0, 4)})` : ''
+        }`;
+        image = `https://image.tmdb.org/t/p/w600_and_h900_bestv2${tvshow.poster_path}`;
+      }
+
+      const [firstComment] = sortBy(issue.comments, 'id');
+
+      if (entity.id !== firstComment.id) {
+        // Send notifications to all issue managers
+        notificationManager.sendNotification(Notification.ISSUE_COMMENT, {
+          event: `New Comment on ${
+            issue.issueType !== IssueType.OTHER
+              ? `${IssueTypeName[issue.issueType]} `
+              : ''
+          }Issue`,
+          subject: title,
+          message: firstComment.message,
+          comment: entity,
+          issue,
+          media,
+          image,
+          notifyAdmin: true,
+          notifyUser:
+            !issue.createdBy.hasPermission(Permission.MANAGE_ISSUES) &&
+            issue.createdBy.id !== entity.user.id
+              ? issue.createdBy
+              : undefined,
+        });
+      }
+    } catch (e) {
+      logger.error(
+        'Something went wrong sending issue comment notification(s)',
+        {
+          label: 'Notifications',
+          errorMessage: e.message,
+          commentId: entity.id,
+        }
+      );
     }
   }
 

server/subscriber/IssueSubscriber.ts

@@ -11,6 +11,7 @@ import { MediaType } from '../constants/media';
 import Issue from '../entity/Issue';
 import notificationManager, { Notification } from '../lib/notifications';
 import { Permission } from '../lib/permissions';
+import logger from '../logger';
 
 @EventSubscriber()
 export class IssueSubscriber implements EntitySubscriberInterface<Issue> {
@@ -22,72 +23,81 @@ export class IssueSubscriber implements EntitySubscriberInterface<Issue> {
     let title: string;
     let image: string;
     const tmdb = new TheMovieDb();
-    if (entity.media.mediaType === MediaType.MOVIE) {
-      const movie = await tmdb.getMovie({ movieId: entity.media.tmdbId });
 
-      title = `${movie.title}${
-        movie.release_date ? ` (${movie.release_date.slice(0, 4)})` : ''
-      }`;
-      image = `https://image.tmdb.org/t/p/w600_and_h900_bestv2${movie.poster_path}`;
-    } else {
-      const tvshow = await tmdb.getTvShow({ tvId: entity.media.tmdbId });
+    try {
+      if (entity.media.mediaType === MediaType.MOVIE) {
+        const movie = await tmdb.getMovie({ movieId: entity.media.tmdbId });
 
-      title = `${tvshow.name}${
-        tvshow.first_air_date ? ` (${tvshow.first_air_date.slice(0, 4)})` : ''
-      }`;
-      image = `https://image.tmdb.org/t/p/w600_and_h900_bestv2${tvshow.poster_path}`;
-    }
+        title = `${movie.title}${
+          movie.release_date ? ` (${movie.release_date.slice(0, 4)})` : ''
+        }`;
+        image = `https://image.tmdb.org/t/p/w600_and_h900_bestv2${movie.poster_path}`;
+      } else {
+        const tvshow = await tmdb.getTvShow({ tvId: entity.media.tmdbId });
 
-    const [firstComment] = sortBy(entity.comments, 'id');
-    const extra: { name: string; value: string }[] = [];
-
-    if (entity.media.mediaType === MediaType.TV && entity.problemSeason > 0) {
-      extra.push({
-        name: 'Affected Season',
-        value: entity.problemSeason.toString(),
-      });
-
-      if (entity.problemEpisode > 0) {
-        extra.push({
-          name: 'Affected Episode',
-          value: entity.problemEpisode.toString(),
-        });
+        title = `${tvshow.name}${
+          tvshow.first_air_date ? ` (${tvshow.first_air_date.slice(0, 4)})` : ''
+        }`;
+        image = `https://image.tmdb.org/t/p/w600_and_h900_bestv2${tvshow.poster_path}`;
       }
-    }
 
-    notificationManager.sendNotification(type, {
-      event:
-        type === Notification.ISSUE_CREATED
-          ? `New ${
-              entity.issueType !== IssueType.OTHER
-                ? `${IssueTypeName[entity.issueType]} `
-                : ''
-            }Issue Reported`
-          : type === Notification.ISSUE_RESOLVED
-          ? `${
-              entity.issueType !== IssueType.OTHER
-                ? `${IssueTypeName[entity.issueType]} `
-                : ''
-            }Issue Resolved`
-          : `${
-              entity.issueType !== IssueType.OTHER
-                ? `${IssueTypeName[entity.issueType]} `
-                : ''
-            }Issue Reopened`,
-      subject: title,
-      message: firstComment.message,
-      issue: entity,
-      media: entity.media,
-      image,
-      extra,
-      notifyAdmin: true,
-      notifyUser:
-        !entity.createdBy.hasPermission(Permission.MANAGE_ISSUES) &&
-        (type === Notification.ISSUE_RESOLVED ||
-          type === Notification.ISSUE_REOPENED)
-          ? entity.createdBy
-          : undefined,
-    });
+      const [firstComment] = sortBy(entity.comments, 'id');
+      const extra: { name: string; value: string }[] = [];
+
+      if (entity.media.mediaType === MediaType.TV && entity.problemSeason > 0) {
+        extra.push({
+          name: 'Affected Season',
+          value: entity.problemSeason.toString(),
+        });
+
+        if (entity.problemEpisode > 0) {
+          extra.push({
+            name: 'Affected Episode',
+            value: entity.problemEpisode.toString(),
+          });
+        }
+      }
+
+      notificationManager.sendNotification(type, {
+        event:
+          type === Notification.ISSUE_CREATED
+            ? `New ${
+                entity.issueType !== IssueType.OTHER
+                  ? `${IssueTypeName[entity.issueType]} `
+                  : ''
+              }Issue Reported`
+            : type === Notification.ISSUE_RESOLVED
+            ? `${
+                entity.issueType !== IssueType.OTHER
+                  ? `${IssueTypeName[entity.issueType]} `
+                  : ''
+              }Issue Resolved`
+            : `${
+                entity.issueType !== IssueType.OTHER
+                  ? `${IssueTypeName[entity.issueType]} `
+                  : ''
+              }Issue Reopened`,
+        subject: title,
+        message: firstComment.message,
+        issue: entity,
+        media: entity.media,
+        image,
+        extra,
+        notifyAdmin: true,
+        notifyUser:
+          !entity.createdBy.hasPermission(Permission.MANAGE_ISSUES) &&
+          (type === Notification.ISSUE_RESOLVED ||
+            type === Notification.ISSUE_REOPENED)
+            ? entity.createdBy
+            : undefined,
+      });
+    } catch (e) {
+      logger.error('Something went wrong sending issue notification(s)', {
+        label: 'Notifications',
+        errorMessage: e.message,
+        issueId: entity.id,
+      });
+    }
   }
 
   public afterInsert(event: InsertEvent<Issue>): void {

server/subscriber/MediaSubscriber.ts

@@ -12,6 +12,7 @@ import Media from '../entity/Media';
 import { MediaRequest } from '../entity/MediaRequest';
 import Season from '../entity/Season';
 import notificationManager, { Notification } from '../lib/notifications';
+import logger from '../logger';
 
 @EventSubscriber()
 export class MediaSubscriber implements EntitySubscriberInterface<Media> {
@@ -36,26 +37,40 @@ export class MediaSubscriber implements EntitySubscriberInterface<Media> {
 
         if (relatedRequests.length > 0) {
           const tmdb = new TheMovieDb();
-          const movie = await tmdb.getMovie({ movieId: entity.tmdbId });
 
-          relatedRequests.forEach((request) => {
-            notificationManager.sendNotification(Notification.MEDIA_AVAILABLE, {
-              event: `${is4k ? '4K ' : ''}Movie Request Now Available`,
-              notifyAdmin: false,
-              notifyUser: request.requestedBy,
-              subject: `${movie.title}${
-                movie.release_date ? ` (${movie.release_date.slice(0, 4)})` : ''
-              }`,
-              message: truncate(movie.overview, {
-                length: 500,
-                separator: /\s/,
-                omission: '…',
-              }),
-              media: entity,
-              image: `https://image.tmdb.org/t/p/w600_and_h900_bestv2${movie.poster_path}`,
-              request,
+          try {
+            const movie = await tmdb.getMovie({ movieId: entity.tmdbId });
+
+            relatedRequests.forEach((request) => {
+              notificationManager.sendNotification(
+                Notification.MEDIA_AVAILABLE,
+                {
+                  event: `${is4k ? '4K ' : ''}Movie Request Now Available`,
+                  notifyAdmin: false,
+                  notifyUser: request.requestedBy,
+                  subject: `${movie.title}${
+                    movie.release_date
+                      ? ` (${movie.release_date.slice(0, 4)})`
+                      : ''
+                  }`,
+                  message: truncate(movie.overview, {
+                    length: 500,
+                    separator: /\s/,
+                    omission: '…',
+                  }),
+                  media: entity,
+                  image: `https://image.tmdb.org/t/p/w600_and_h900_bestv2${movie.poster_path}`,
+                  request,
+                }
+              );
             });
-          });
+          } catch (e) {
+            logger.error('Something went wrong sending media notification(s)', {
+              label: 'Notifications',
+              errorMessage: e.message,
+              mediaId: entity.id,
+            });
+          }
         }
       }
     }
@@ -114,31 +129,40 @@ export class MediaSubscriber implements EntitySubscriberInterface<Media> {
           processedSeasons.push(
             ...request.seasons.map((season) => season.seasonNumber)
           );
-          const tv = await tmdb.getTvShow({ tvId: entity.tmdbId });
-          notificationManager.sendNotification(Notification.MEDIA_AVAILABLE, {
-            event: `${is4k ? '4K ' : ''}Series Request Now Available`,
-            subject: `${tv.name}${
-              tv.first_air_date ? ` (${tv.first_air_date.slice(0, 4)})` : ''
-            }`,
-            message: truncate(tv.overview, {
-              length: 500,
-              separator: /\s/,
-              omission: '…',
-            }),
-            notifyAdmin: false,
-            notifyUser: request.requestedBy,
-            image: `https://image.tmdb.org/t/p/w600_and_h900_bestv2${tv.poster_path}`,
-            media: entity,
-            extra: [
-              {
-                name: 'Requested Seasons',
-                value: request.seasons
-                  .map((season) => season.seasonNumber)
-                  .join(', '),
-              },
-            ],
-            request,
-          });
+
+          try {
+            const tv = await tmdb.getTvShow({ tvId: entity.tmdbId });
+            notificationManager.sendNotification(Notification.MEDIA_AVAILABLE, {
+              event: `${is4k ? '4K ' : ''}Series Request Now Available`,
+              subject: `${tv.name}${
+                tv.first_air_date ? ` (${tv.first_air_date.slice(0, 4)})` : ''
+              }`,
+              message: truncate(tv.overview, {
+                length: 500,
+                separator: /\s/,
+                omission: '…',
+              }),
+              notifyAdmin: false,
+              notifyUser: request.requestedBy,
+              image: `https://image.tmdb.org/t/p/w600_and_h900_bestv2${tv.poster_path}`,
+              media: entity,
+              extra: [
+                {
+                  name: 'Requested Seasons',
+                  value: request.seasons
+                    .map((season) => season.seasonNumber)
+                    .join(', '),
+                },
+              ],
+              request,
+            });
+          } catch (e) {
+            logger.error('Something went wrong sending media notification(s)', {
+              label: 'Notifications',
+              errorMessage: e.message,
+              mediaId: entity.id,
+            });
+          }
         }
       }
     }