refactor: update a few dev deps and convert to using type imports where possible (#2886)

* build: bump deps and add some new eslint rules

* refactor: run eslint --fix on code to convert to type imports where possible

server/lib/email/index.ts

@@ -1,7 +1,8 @@
 import Email from 'email-templates';
 import nodemailer from 'nodemailer';
 import { URL } from 'url';
-import { getSettings, NotificationAgentEmail } from '../settings';
+import type { NotificationAgentEmail } from '../settings';
+import { getSettings } from '../settings';
 import { openpgpEncrypt } from './openpgpEncrypt';
 
 class PreparedEmail extends Email {

server/lib/email/openpgpEncrypt.ts

@@ -1,6 +1,7 @@
 import { randomBytes } from 'crypto';
 import * as openpgp from 'openpgp';
-import { Transform, TransformCallback } from 'stream';
+import type { TransformCallback } from 'stream';
+import { Transform } from 'stream';
 import logger from '../../logger';
 
 interface EncryptorOptions {

server/lib/notifications/agents/agent.ts

@@ -1,10 +1,10 @@
-import { Notification } from '..';
+import type { Notification } from '..';
 import type Issue from '../../../entity/Issue';
-import IssueComment from '../../../entity/IssueComment';
-import Media from '../../../entity/Media';
-import { MediaRequest } from '../../../entity/MediaRequest';
-import { User } from '../../../entity/User';
-import { NotificationAgentConfig } from '../../settings';
+import type IssueComment from '../../../entity/IssueComment';
+import type Media from '../../../entity/Media';
+import type { MediaRequest } from '../../../entity/MediaRequest';
+import type { User } from '../../../entity/User';
+import type { NotificationAgentConfig } from '../../settings';
 
 export interface NotificationPayload {
   event?: string;

server/lib/notifications/agents/discord.ts

@@ -8,12 +8,10 @@ import {
 import { IssueStatus, IssueTypeName } from '../../../constants/issue';
 import { User } from '../../../entity/User';
 import logger from '../../../logger';
-import {
-  getSettings,
-  NotificationAgentDiscord,
-  NotificationAgentKey,
-} from '../../settings';
-import { BaseAgent, NotificationAgent, NotificationPayload } from './agent';
+import type { NotificationAgentDiscord } from '../../settings';
+import { getSettings, NotificationAgentKey } from '../../settings';
+import type { NotificationAgent, NotificationPayload } from './agent';
+import { BaseAgent } from './agent';
 
 enum EmbedColors {
   DEFAULT = 0,

server/lib/notifications/agents/email.ts

@@ -1,4 +1,4 @@
-import { EmailOptions } from 'email-templates';
+import type { EmailOptions } from 'email-templates';
 import path from 'path';
 import { getRepository } from 'typeorm';
 import { Notification, shouldSendAdminNotification } from '..';
@@ -7,12 +7,10 @@ import { MediaType } from '../../../constants/media';
 import { User } from '../../../entity/User';
 import logger from '../../../logger';
 import PreparedEmail from '../../email';
-import {
-  getSettings,
-  NotificationAgentEmail,
-  NotificationAgentKey,
-} from '../../settings';
-import { BaseAgent, NotificationAgent, NotificationPayload } from './agent';
+import type { NotificationAgentEmail } from '../../settings';
+import { getSettings, NotificationAgentKey } from '../../settings';
+import type { NotificationAgent, NotificationPayload } from './agent';
+import { BaseAgent } from './agent';
 
 class EmailAgent
   extends BaseAgent<NotificationAgentEmail>

server/lib/notifications/agents/gotify.ts

@@ -2,8 +2,10 @@ import axios from 'axios';
 import { hasNotificationType, Notification } from '..';
 import { IssueStatus, IssueTypeName } from '../../../constants/issue';
 import logger from '../../../logger';
-import { getSettings, NotificationAgentGotify } from '../../settings';
-import { BaseAgent, NotificationAgent, NotificationPayload } from './agent';
+import type { NotificationAgentGotify } from '../../settings';
+import { getSettings } from '../../settings';
+import type { NotificationAgent, NotificationPayload } from './agent';
+import { BaseAgent } from './agent';
 
 interface GotifyPayload {
   title: string;

server/lib/notifications/agents/lunasea.ts

@@ -3,8 +3,10 @@ import { hasNotificationType, Notification } from '..';
 import { IssueStatus, IssueType } from '../../../constants/issue';
 import { MediaStatus } from '../../../constants/media';
 import logger from '../../../logger';
-import { getSettings, NotificationAgentLunaSea } from '../../settings';
-import { BaseAgent, NotificationAgent, NotificationPayload } from './agent';
+import type { NotificationAgentLunaSea } from '../../settings';
+import { getSettings } from '../../settings';
+import type { NotificationAgent, NotificationPayload } from './agent';
+import { BaseAgent } from './agent';
 
 class LunaSeaAgent
   extends BaseAgent<NotificationAgentLunaSea>

server/lib/notifications/agents/pushbullet.ts

@@ -8,12 +8,10 @@ import {
 import { IssueStatus, IssueTypeName } from '../../../constants/issue';
 import { User } from '../../../entity/User';
 import logger from '../../../logger';
-import {
-  getSettings,
-  NotificationAgentKey,
-  NotificationAgentPushbullet,
-} from '../../settings';
-import { BaseAgent, NotificationAgent, NotificationPayload } from './agent';
+import type { NotificationAgentPushbullet } from '../../settings';
+import { getSettings, NotificationAgentKey } from '../../settings';
+import type { NotificationAgent, NotificationPayload } from './agent';
+import { BaseAgent } from './agent';
 
 interface PushbulletPayload {
   type: string;

server/lib/notifications/agents/pushover.ts

@@ -8,12 +8,10 @@ import {
 import { IssueStatus, IssueTypeName } from '../../../constants/issue';
 import { User } from '../../../entity/User';
 import logger from '../../../logger';
-import {
-  getSettings,
-  NotificationAgentKey,
-  NotificationAgentPushover,
-} from '../../settings';
-import { BaseAgent, NotificationAgent, NotificationPayload } from './agent';
+import type { NotificationAgentPushover } from '../../settings';
+import { getSettings, NotificationAgentKey } from '../../settings';
+import type { NotificationAgent, NotificationPayload } from './agent';
+import { BaseAgent } from './agent';
 
 interface PushoverPayload {
   token: string;

server/lib/notifications/agents/slack.ts

@@ -2,8 +2,10 @@ import axios from 'axios';
 import { hasNotificationType, Notification } from '..';
 import { IssueStatus, IssueTypeName } from '../../../constants/issue';
 import logger from '../../../logger';
-import { getSettings, NotificationAgentSlack } from '../../settings';
-import { BaseAgent, NotificationAgent, NotificationPayload } from './agent';
+import type { NotificationAgentSlack } from '../../settings';
+import { getSettings } from '../../settings';
+import type { NotificationAgent, NotificationPayload } from './agent';
+import { BaseAgent } from './agent';
 
 interface EmbedField {
   type: 'plain_text' | 'mrkdwn';

server/lib/notifications/agents/telegram.ts

@@ -8,12 +8,10 @@ import {
 import { IssueStatus, IssueTypeName } from '../../../constants/issue';
 import { User } from '../../../entity/User';
 import logger from '../../../logger';
-import {
-  getSettings,
-  NotificationAgentKey,
-  NotificationAgentTelegram,
-} from '../../settings';
-import { BaseAgent, NotificationAgent, NotificationPayload } from './agent';
+import type { NotificationAgentTelegram } from '../../settings';
+import { getSettings, NotificationAgentKey } from '../../settings';
+import type { NotificationAgent, NotificationPayload } from './agent';
+import { BaseAgent } from './agent';
 
 interface TelegramMessagePayload {
   text: string;

server/lib/notifications/agents/webhook.ts

@@ -4,8 +4,10 @@ import { hasNotificationType, Notification } from '..';
 import { IssueStatus, IssueType } from '../../../constants/issue';
 import { MediaStatus } from '../../../constants/media';
 import logger from '../../../logger';
-import { getSettings, NotificationAgentWebhook } from '../../settings';
-import { BaseAgent, NotificationAgent, NotificationPayload } from './agent';
+import type { NotificationAgentWebhook } from '../../settings';
+import { getSettings } from '../../settings';
+import type { NotificationAgent, NotificationPayload } from './agent';
+import { BaseAgent } from './agent';
 
 type KeyMapFunction = (
   payload: NotificationPayload,

server/lib/notifications/agents/webpush.ts

@@ -6,12 +6,10 @@ import { MediaType } from '../../../constants/media';
 import { User } from '../../../entity/User';
 import { UserPushSubscription } from '../../../entity/UserPushSubscription';
 import logger from '../../../logger';
-import {
-  getSettings,
-  NotificationAgentConfig,
-  NotificationAgentKey,
-} from '../../settings';
-import { BaseAgent, NotificationAgent, NotificationPayload } from './agent';
+import type { NotificationAgentConfig } from '../../settings';
+import { getSettings, NotificationAgentKey } from '../../settings';
+import type { NotificationAgent, NotificationPayload } from './agent';
+import { BaseAgent } from './agent';
 
 interface PushNotificationPayload {
   notificationType: string;

server/lib/notifications/index.ts

@@ -1,4 +1,4 @@
-import { User } from '../../entity/User';
+import type { User } from '../../entity/User';
 import logger from '../../logger';
 import { Permission } from '../permissions';
 import type { NotificationAgent, NotificationPayload } from './agents/agent';

server/lib/scanners/plex/index.ts

@@ -1,17 +1,20 @@
 import { uniqWith } from 'lodash';
 import { getRepository } from 'typeorm';
 import animeList from '../../../api/animelist';
-import PlexAPI, { PlexLibraryItem, PlexMetadata } from '../../../api/plexapi';
-import { TmdbTvDetails } from '../../../api/themoviedb/interfaces';
+import type { PlexLibraryItem, PlexMetadata } from '../../../api/plexapi';
+import PlexAPI from '../../../api/plexapi';
+import type { TmdbTvDetails } from '../../../api/themoviedb/interfaces';
 import { User } from '../../../entity/User';
 import cacheManager from '../../cache';
-import { getSettings, Library } from '../../settings';
-import BaseScanner, {
+import type { Library } from '../../settings';
+import { getSettings } from '../../settings';
+import type {
   MediaIds,
   ProcessableSeason,
   RunnableScanner,
   StatusBase,
 } from '../baseScanner';
+import BaseScanner from '../baseScanner';
 
 const imdbRegex = new RegExp(/imdb:\/\/(tt[0-9]+)/);
 const tmdbRegex = new RegExp(/tmdb:\/\/([0-9]+)/);

server/lib/scanners/radarr/index.ts

@@ -1,7 +1,10 @@
 import { uniqWith } from 'lodash';
-import RadarrAPI, { RadarrMovie } from '../../../api/servarr/radarr';
-import { getSettings, RadarrSettings } from '../../settings';
-import BaseScanner, { RunnableScanner, StatusBase } from '../baseScanner';
+import type { RadarrMovie } from '../../../api/servarr/radarr';
+import RadarrAPI from '../../../api/servarr/radarr';
+import type { RadarrSettings } from '../../settings';
+import { getSettings } from '../../settings';
+import type { RunnableScanner, StatusBase } from '../baseScanner';
+import BaseScanner from '../baseScanner';
 
 type SyncStatus = StatusBase & {
   currentServer: RadarrSettings;

server/lib/scanners/sonarr/index.ts

@@ -1,14 +1,17 @@
 import { uniqWith } from 'lodash';
 import { getRepository } from 'typeorm';
-import SonarrAPI, { SonarrSeries } from '../../../api/servarr/sonarr';
-import { TmdbTvDetails } from '../../../api/themoviedb/interfaces';
+import type { SonarrSeries } from '../../../api/servarr/sonarr';
+import SonarrAPI from '../../../api/servarr/sonarr';
+import type { TmdbTvDetails } from '../../../api/themoviedb/interfaces';
 import Media from '../../../entity/Media';
-import { getSettings, SonarrSettings } from '../../settings';
-import BaseScanner, {
+import type { SonarrSettings } from '../../settings';
+import { getSettings } from '../../settings';
+import type {
   ProcessableSeason,
   RunnableScanner,
   StatusBase,
 } from '../baseScanner';
+import BaseScanner from '../baseScanner';
 
 type SyncStatus = StatusBase & {
   currentServer: SonarrSettings;

server/lib/search.ts

@@ -1,5 +1,5 @@
 import TheMovieDb from '../api/themoviedb';
-import {
+import type {
   TmdbMovieDetails,
   TmdbMovieResult,
   TmdbPersonDetails,