important bug fix.

2024-11-20 11:57:01 -07:00
parent 210b27ab25
commit b6c5cd4b46
1 changed files with 6 additions and 3 deletions
--- a/Controllers/Vehicle/SupplyController.cs
+++ b/Controllers/Vehicle/SupplyController.cs
@@ -227,10 +227,13 @@ namespace CarCareTracker.Controllers
        private bool DeleteSupplyRecordWithChecks(int supplyRecordId)
        {
            var existingRecord = _supplyRecordDataAccess.GetSupplyRecordById(supplyRecordId);
-            //security check.
-            if (!_userLogic.UserCanEditVehicle(GetUserID(), existingRecord.VehicleId))
+            if (existingRecord.VehicleId != default)
            {
-                return false;
+                //security check only if not editing shop supply.
+                if (!_userLogic.UserCanEditVehicle(GetUserID(), existingRecord.VehicleId))
+                {
+                    return false;
+                }
            }
            var result = _supplyRecordDataAccess.DeleteSupplyRecordById(existingRecord.Id);
            return result;